Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: surface errors based on status code #1484

Merged
merged 5 commits into from
Feb 1, 2024
Merged

http: surface errors based on status code #1484

merged 5 commits into from
Feb 1, 2024

Conversation

jaymell
Copy link
Contributor

@jaymell jaymell commented Jan 19, 2024

Fixes #1275

Changes

Surfacing these errors is valuable for troubleshooting configuration issues.

Also modify ResponseExt to return the more generic HttpError.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@jaymell
http: surface errors based on status code
dce8f87 
Surfacing these errors is valuable for troubleshooting
configuration issues.

Also modify `ResponseExt` to return the more generic `HttpError`.

Fixes open-telemetry#1275.
@jaymell jaymell requested a review from a team as a code owner January 19, 2024 07:01
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 19, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

jtescher
jtescher approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaymell this looks good, mind adding a changelog entry?

@jaymell
Copy link
Contributor Author

jaymell commented Jan 23, 2024

Thanks @jaymell this looks good, mind adding a changelog entry?

Sure! I guess I should add the change in signature on ResponseExt as a breaking change? Practically speaking, it seems unlikely to cause issues but certainly not impossible.

@cijothomas cijothomas merged commit 270c857 into open-telemetry:main Feb 1, 2024
12 of 13 checks passed
@jaymell jaymell deleted the surface-http-status-errors branch February 16, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtescher jtescher jtescher approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opentelemetry-otlp exporter with http-proto: should it error on unsuccessful status code?
3 participants
@jaymell @jtescher @cijothomas